clearlinux/docker
2
0
Fork 0
mirror of https://github.com/clearlinux/docker.git synced 2026-10-04 15:58:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10082 from jfrazelle/10081-fix-renaming

Browse Source 
Renaming a container with an invalid name should fail
This commit is contained in:
Victor Vieux
2015-01-14 13:12:36 -08:00
parent 37b69408f8 a92281637f
commit f67c6d313b
2 changed files with 33 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
integration-cli/docker_cli_rename_test.go
+20
View File
@@ -97,3 +97,23 @@ func TestRenameCheckNames(t *testing.T) {
logDone("rename - running container")
}
func TestRenameInvalidName(t *testing.T) {
defer deleteAllContainers()
runCmd := exec.Command(dockerBinary, "run", "--name", "myname", "-d", "busybox", "top")
if out, _, err := runCommandWithOutput(runCmd); err != nil {
t.Fatalf(out, err)
}
runCmd = exec.Command(dockerBinary, "rename", "myname", "new:invalid")
if out, _, err := runCommandWithOutput(runCmd); err == nil || !strings.Contains(out, "Invalid container name") {
t.Fatalf("Renaming container to invalid name should have failed: %s\n%v", out, err)
}
runCmd = exec.Command(dockerBinary, "ps", "-a")
if out, _, err := runCommandWithOutput(runCmd); err != nil || !strings.Contains(out, "myname") {
t.Fatalf("Output of docker ps should have included 'myname': %s\n%v", out, err)
}
logDone("rename - invalid container name")
}