mirror of
https://github.com/clearlinux/docker.git
synced 2026-10-04 15:58:39 +00:00
Use suite for integration-cli
It prints test name and duration for each test. Also performs deleteAllContainers after each test. Signed-off-by: Alexander Morozov <lk4d4@docker.com>
This commit is contained in:
@@ -3,16 +3,16 @@ package main
|
||||
import (
|
||||
"os/exec"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/go-check/check"
|
||||
)
|
||||
|
||||
func TestRenameStoppedContainer(t *testing.T) {
|
||||
defer deleteAllContainers()
|
||||
func (s *DockerSuite) TestRenameStoppedContainer(c *check.C) {
|
||||
|
||||
runCmd := exec.Command(dockerBinary, "run", "--name", "first_name", "-d", "busybox", "sh")
|
||||
out, _, err := runCommandWithOutput(runCmd)
|
||||
if err != nil {
|
||||
t.Fatalf(out, err)
|
||||
c.Fatalf(out, err)
|
||||
}
|
||||
|
||||
cleanedContainerID := strings.TrimSpace(out)
|
||||
@@ -20,7 +20,7 @@ func TestRenameStoppedContainer(t *testing.T) {
|
||||
runCmd = exec.Command(dockerBinary, "wait", cleanedContainerID)
|
||||
out, _, err = runCommandWithOutput(runCmd)
|
||||
if err != nil {
|
||||
t.Fatalf(out, err)
|
||||
c.Fatalf(out, err)
|
||||
}
|
||||
|
||||
name, err := inspectField(cleanedContainerID, "Name")
|
||||
@@ -28,94 +28,87 @@ func TestRenameStoppedContainer(t *testing.T) {
|
||||
runCmd = exec.Command(dockerBinary, "rename", "first_name", "new_name")
|
||||
out, _, err = runCommandWithOutput(runCmd)
|
||||
if err != nil {
|
||||
t.Fatalf(out, err)
|
||||
c.Fatalf(out, err)
|
||||
}
|
||||
|
||||
name, err = inspectField(cleanedContainerID, "Name")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
c.Fatal(err)
|
||||
}
|
||||
if name != "/new_name" {
|
||||
t.Fatal("Failed to rename container ", name)
|
||||
c.Fatal("Failed to rename container ", name)
|
||||
}
|
||||
|
||||
logDone("rename - stopped container")
|
||||
}
|
||||
|
||||
func TestRenameRunningContainer(t *testing.T) {
|
||||
defer deleteAllContainers()
|
||||
func (s *DockerSuite) TestRenameRunningContainer(c *check.C) {
|
||||
|
||||
runCmd := exec.Command(dockerBinary, "run", "--name", "first_name", "-d", "busybox", "sh")
|
||||
out, _, err := runCommandWithOutput(runCmd)
|
||||
if err != nil {
|
||||
t.Fatalf(out, err)
|
||||
c.Fatalf(out, err)
|
||||
}
|
||||
|
||||
cleanedContainerID := strings.TrimSpace(out)
|
||||
runCmd = exec.Command(dockerBinary, "rename", "first_name", "new_name")
|
||||
out, _, err = runCommandWithOutput(runCmd)
|
||||
if err != nil {
|
||||
t.Fatalf(out, err)
|
||||
c.Fatalf(out, err)
|
||||
}
|
||||
|
||||
name, err := inspectField(cleanedContainerID, "Name")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
c.Fatal(err)
|
||||
}
|
||||
if name != "/new_name" {
|
||||
t.Fatal("Failed to rename container ")
|
||||
c.Fatal("Failed to rename container ")
|
||||
}
|
||||
|
||||
logDone("rename - running container")
|
||||
}
|
||||
|
||||
func TestRenameCheckNames(t *testing.T) {
|
||||
defer deleteAllContainers()
|
||||
func (s *DockerSuite) TestRenameCheckNames(c *check.C) {
|
||||
|
||||
runCmd := exec.Command(dockerBinary, "run", "--name", "first_name", "-d", "busybox", "sh")
|
||||
out, _, err := runCommandWithOutput(runCmd)
|
||||
if err != nil {
|
||||
t.Fatalf(out, err)
|
||||
c.Fatalf(out, err)
|
||||
}
|
||||
|
||||
runCmd = exec.Command(dockerBinary, "rename", "first_name", "new_name")
|
||||
out, _, err = runCommandWithOutput(runCmd)
|
||||
if err != nil {
|
||||
t.Fatalf(out, err)
|
||||
c.Fatalf(out, err)
|
||||
}
|
||||
|
||||
name, err := inspectField("new_name", "Name")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
c.Fatal(err)
|
||||
}
|
||||
if name != "/new_name" {
|
||||
t.Fatal("Failed to rename container ")
|
||||
c.Fatal("Failed to rename container ")
|
||||
}
|
||||
|
||||
name, err = inspectField("first_name", "Name")
|
||||
if err == nil && !strings.Contains(err.Error(), "No such image or container: first_name") {
|
||||
t.Fatal(err)
|
||||
c.Fatal(err)
|
||||
}
|
||||
|
||||
logDone("rename - old name released")
|
||||
}
|
||||
|
||||
func TestRenameInvalidName(t *testing.T) {
|
||||
defer deleteAllContainers()
|
||||
func (s *DockerSuite) TestRenameInvalidName(c *check.C) {
|
||||
runCmd := exec.Command(dockerBinary, "run", "--name", "myname", "-d", "busybox", "top")
|
||||
if out, _, err := runCommandWithOutput(runCmd); err != nil {
|
||||
t.Fatalf(out, err)
|
||||
c.Fatalf(out, err)
|
||||
}
|
||||
|
||||
runCmd = exec.Command(dockerBinary, "rename", "myname", "new:invalid")
|
||||
if out, _, err := runCommandWithOutput(runCmd); err == nil || !strings.Contains(out, "Invalid container name") {
|
||||
t.Fatalf("Renaming container to invalid name should have failed: %s\n%v", out, err)
|
||||
c.Fatalf("Renaming container to invalid name should have failed: %s\n%v", out, err)
|
||||
}
|
||||
|
||||
runCmd = exec.Command(dockerBinary, "ps", "-a")
|
||||
if out, _, err := runCommandWithOutput(runCmd); err != nil || !strings.Contains(out, "myname") {
|
||||
t.Fatalf("Output of docker ps should have included 'myname': %s\n%v", out, err)
|
||||
c.Fatalf("Output of docker ps should have included 'myname': %s\n%v", out, err)
|
||||
}
|
||||
|
||||
logDone("rename - invalid container name")
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user