clearlinux/docker
2
0
Fork 0
mirror of https://github.com/clearlinux/docker.git synced 2026-09-08 15:01:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7996 from estesp/7943-validate-tagnames

Browse Source 
Validate tag names similar to repository name validation; add tests
This commit is contained in:
Michael Crosby
2014-09-11 15:19:50 -07:00
parent 2d4e43b26b 46eb4140c9
commit 98e409172c
2 changed files with 26 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
integration-cli/docker_cli_tag_test.go
+19 -8
View File
@@ -37,23 +37,34 @@ func TestTagUnprefixedRepoByID(t *testing.T) {
logDone("tag - busybox's image ID -> testfoobarbaz")
}
// ensure we don't allow the use of invalid tags; these tag operations should fail
// ensure we don't allow the use of invalid repository names; these tag operations should fail
func TestTagInvalidUnprefixedRepo(t *testing.T) {
// skip this until we start blocking bad tags
t.Skip()
invalidRepos := []string{"-foo", "fo$z$", "Foo@3cc", "Foo$3", "Foo*3", "Fo^3", "Foo!3", "F)xcz(", "fo", "f"}
invalidRepos := []string{"fo$z$", "Foo@3cc", "Foo$3", "Foo*3", "Fo^3", "Foo!3", "F)xcz(", "fo%asd"}
for _, repo := range invalidRepos {
tagCmd := exec.Command(dockerBinary, "tag", "busybox", repo)
_, _, err := runCommandWithOutput(tagCmd)
if err == nil {
t.Errorf("tag busybox %v should have failed", repo)
continue
t.Fatalf("tag busybox %v should have failed", repo)
}
logMessage := fmt.Sprintf("tag - busybox %v --> must fail", repo)
logDone(logMessage)
}
logDone("tag - busybox invalid repo names --> must fail")
}
// ensure we don't allow the use of invalid tags; these tag operations should fail
func TestTagInvalidPrefixedRepo(t *testing.T) {
invalidTags := []string{"repo:fo$z$", "repo:Foo@3cc", "repo:Foo$3", "repo:Foo*3", "repo:Fo^3", "repo:Foo!3", "repo:%goodbye", "repo:#hashtagit", "repo:F)xcz(", "repo:f", "repo:fwaytoolongandwaymorethan30characterslong", "repo:-foo", "repo:.."}
for _, repotag := range invalidTags {
tagCmd := exec.Command(dockerBinary, "tag", "busybox", repotag)
_, _, err := runCommandWithOutput(tagCmd)
if err == nil {
t.Fatalf("tag busybox %v should have failed", repotag)
}
}
logDone("tag - busybox with invalid repo:tagnames --> must fail")
}
// ensure we allow the use of valid tags