From 8e4d9f3cf9669f45b0591eea27c47b6f64d89c2d Mon Sep 17 00:00:00 2001 From: Brian Goff Date: Sat, 21 Mar 2015 16:57:22 -0400 Subject: [PATCH] Improve err message when parsing kernel port range Signed-off-by: Brian Goff --- daemon/networkdriver/portallocator/portallocator.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/daemon/networkdriver/portallocator/portallocator.go b/daemon/networkdriver/portallocator/portallocator.go index da9f98739..3a4f8e6ae 100644 --- a/daemon/networkdriver/portallocator/portallocator.go +++ b/daemon/networkdriver/portallocator/portallocator.go @@ -70,10 +70,11 @@ func NewErrPortAlreadyAllocated(ip string, port int) ErrPortAlreadyAllocated { func init() { const portRangeKernelParam = "/proc/sys/net/ipv4/ip_local_port_range" + portRangeFallback := fmt.Sprintf("using fallback port range %d-%d", beginPortRange, endPortRange) file, err := os.Open(portRangeKernelParam) if err != nil { - log.Warnf("Failed to read %s kernel parameter: %v", portRangeKernelParam, err) + log.Warnf("port allocator - %s due to error: %v", portRangeFallback, err) return } var start, end int @@ -82,7 +83,7 @@ func init() { if err == nil { err = fmt.Errorf("unexpected count of parsed numbers (%d)", n) } - log.Errorf("Failed to parse port range from %s: %v", portRangeKernelParam, err) + log.Errorf("port allocator - failed to parse system ephemeral port range from %s - %s: %v", portRangeKernelParam, portRangeFallback, err) return } beginPortRange = start