clearlinux/docker
2
0
Fork 0
mirror of https://github.com/clearlinux/docker.git synced 2026-09-05 13:11:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clean up dup. volume test and add API test for the same

Browse Source 
Handles missed comments in PR#10622 and adds an API test to validate
error returned properly for duplicate bind mounts for the same
container target path.

Docker-DCO-1.1-Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com> (github: estesp)
This commit is contained in:
Phil Estes
2015-02-09 12:33:58 -05:00
parent a98355561d
commit 35d4825838
2 changed files with 54 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
integration-cli/docker_cli_run_test.go
+17 -1
View File
@@ -495,7 +495,23 @@ func TestVolumesFromGetsProperMode(t *testing.T) {
// Test for GH#10618
func TestRunNoDupVolumes(t *testing.T) {
cmd := exec.Command(dockerBinary, "run", "-v", "/etc:/someplace", "-v", "/usr/lib:/someplace", "busybox", "echo", "hi")
bindPath1, err := ioutil.TempDir("", "test1")
if err != nil {
t.Fatal(err)
}
defer os.Remove(bindPath1)
bindPath2, err := ioutil.TempDir("", "test2")
if err != nil {
t.Fatal(err)
}
defer os.Remove(bindPath2)
mountstr1 := bindPath1 + ":/someplace"
mountstr2 := bindPath2 + ":/someplace"
cmd := exec.Command(dockerBinary, "run", "-v", mountstr1, "-v", mountstr2, "busybox", "true")
if out, _, err := runCommandWithOutput(cmd); err == nil {
t.Fatal("Expected error about duplicate volume definitions")
} else {