clearlinux/docker
2
0
Fork 0
mirror of https://github.com/clearlinux/docker.git synced 2026-09-05 13:11:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10622 from estesp/10618-err-ondup-bind-vols

Browse Source 
Don't allow duplicate `-v` specifications for the same target
This commit is contained in:
Jessie Frazelle
2015-02-06 15:03:56 -08:00
parent eb79acd7a0 d1f33d12d4
commit 271a073a04
2 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
integration-cli/docker_cli_run_test.go
+15
View File
@@ -493,6 +493,21 @@ func TestVolumesFromGetsProperMode(t *testing.T) {
logDone("run - volumes from ignores `rw` if inherrited volume is `ro`")
}
// Test for GH#10618
func TestRunNoDupVolumes(t *testing.T) {
cmd := exec.Command(dockerBinary, "run", "-v", "/etc:/someplace", "-v", "/usr/lib:/someplace", "busybox", "echo", "hi")
if out, _, err := runCommandWithOutput(cmd); err == nil {
t.Fatal("Expected error about duplicate volume definitions")
} else {
if !strings.Contains(out, "Duplicate volume") {
t.Fatalf("Expected 'duplicate volume' error, got %v", err)
}
}
deleteAllContainers()
logDone("run - don't allow multiple (bind) volumes on the same container target")
}
// Test for #1351
func TestRunApplyVolumesFromBeforeVolumes(t *testing.T) {
cmd := exec.Command(dockerBinary, "run", "--name", "parent", "-v", "/test", "busybox", "touch", "/test/foo")