From facfc57d55aead91d5eb1003e02cbf1ac53054bd Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Wed, 12 Jun 2019 14:52:13 -0700 Subject: [PATCH] Update message for the for-review.txt on how to recreate People SHOULD update commit messages if it's not a simple bump or version update. Signed-off-by: Thiago Macieira --- Makefile.common | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/Makefile.common b/Makefile.common index 7aa56c3..605c4d3 100644 --- a/Makefile.common +++ b/Makefile.common @@ -186,12 +186,19 @@ autospec: preautospec-checks pullrebase localreponotice clean-old-content bash update_changelog.sh ; \ git commit --amend --no-edit Change* ; \ fi - @git diff | grep -q index || python3 $(TOPLVL)/projects/common/patchfilter.py > for-review.txt ; + @$(MAKE) -s for-review.txt @printf "\n**\n" @printf "** NOTICE: A patch with changes is available in the file for-review.txt\n" - @printf "** Please submit for code review with git send-email\n" + @printf "** To recreate (e.g., after git commit --amend), run make for-review.txt\n" + @printf "** To submit for review: git send-email --to for-review.txt\n" @printf "**\n\n" +#help for-review.txt: Creates the for-review.txt file, which is +#help a minimized version of the Git commit, suitable for code review. +for-review.txt: + git diff | grep -q index || python3 $(TOPLVL)/projects/common/patchfilter.py > for-review.txt +.PHONY: for-review.txt + #help autospecnogit: Runs autospec, but does not create a commit autospecnogit: $(MAKE) SKIP_GIT=--skip-git autospec