Several API changes from gotk3 v0.4.0 to v0.6.0
which was a required bump to support building under golang 1.16.x.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Change the AutoUpdate model type from bool to boolset to account
for default of true and state if the value was explicitly set.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
a.) By default, block destructive install affecting other disks
b.) Add way to report effects on other disks
c.) Add force-install option
d.) Add Cleanup progress
e.) Fixes
Signed-off-by: Karthik Prabhu Vinod <karthik.prabhu.vinod@intel.com>
New default is the creation of a /var/swapfile if not
swap partition is explicitly defined in the YAML file
or via Advanced Configuration.
Now use and report media sizes in XiB
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Removed exemptions for gocyclo lint for all
storage code except funcs: UnmarshalJSON
& NewDiskConfigPage have inevitable
function exemptions
Signed-off-by: Karthik Prabhu Vinod <karthik.prabhu.vinod@intel.com>
Use the new --skip-validation-size flag to ignore the size
sanity minimums during the user interface installations.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Fixes: #517
Enable the possibility of no /boot partition in legacy mode.
- add warning if no /boot and legacy
Warn the user that installing in legacy mode without a /boot
partition means the install will never boot in UEFI mode.
- Force off 64bit mode
When an ext file system is used for the /boot content
(no /boot partition, and booting legacy mode) we need to
disable 64bit flag or the image file system not boot.
https://wiki.syslinux.org/wiki/index.php?title=Filesystem#ext
- Blocked use of XFS due to partition table requirement to use MBR.
- Do not allow encryption of / w/o /boot
Refactor validation code for reuse by both standard and advanced
disk partitioning. Add new standard Desktop and Server wrapper
functions.
Move validation to common function, remove from Find Targets, and
remove redundant validation function.
Enable the skip size for advanced partitions.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Fixes Issue: #635
The user used to mistakenly click on items in the additonal bundles
page having to wait long duration unecessarily if the network did not work.
This provides the user with a Note saying that selecting an additional
bundle requires a working internet connection
Signed-off-by: Karthik Prabhu Vinod <karthik.prabhu.vinod@intel.com>
Fixes: #600
Only copy the swupd configuration files from the host to the target
by default when running the interactive installer (gui or tui).
Otherwise, observe the setting from the configuration YAML or the
command line (highest) argument.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Fixes: #614
Ensure we retain the selected disk from the chooser box
during refresh like setting an encryption password.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Ensure we do not allow the user to set options, either
via command line or in the default configuration file,
which would not be valid during an interactive installation.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Now printPrefix is concatenated into the progress bar description. The
printPrefix is only intended for the mass installer, so it is removed
from the gui/tui progress bar descriptions.
Signed-off-by: John Akre <john.w.akre@intel.com>
When using advanced disk partitioning with an invalid setup and loading
the menu page or disk configuration page for the first time, the warning
messages were not set correctly. The warnings were incorrectly set
because the TargetMedias variable was unexpectedly overwritten to nil.
This change prevents unexpected overwrites of TargetMedias and sets
TargetMedias when it is uninitialized.
Fixes: #553
Signed-off-by: John Akre <john.w.akre@intel.com>
The IsValidMirror function was moved to the network package and renamed
to IsValidURI because it can be used for more than swupd mirror validation.
The IsValidURI function is used to check for supported URI protocols.
Signed-off-by: John Akre <john.w.akre@intel.com>
This ensures that user is able to proceed through installer
with low resolutions.
This commit also removes hardcoded placement of 'change language'
button (See removed TODO).
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
This is done to ensure that installer can be run on virtual
machines that have a small default screen size.
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Fixes: #478
Add new --allow-insecure-http flag to support the use of HTTP URLs.
This is needed to allow swupd to download content from http sites;
generally development mixes.
Also enable the use of the setting in both the TUI and GUI to allow
the user to set a swupd mirror which is HTTP.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
The saveMedias variable is responsible for selecting between loading the
page or resetting page state on cancel button clicks. When clicking the
confirm button, saveMedias must be set to nil to prevent flipping the
logic for loading the page and cancel button clicks. This logic
inversion led to incorrect menu descriptions for the disk config page.
Signed-off-by: John Akre <john.w.akre@intel.com>
Fixes: #533
Change from partition label to partition name to be consistent
with how the data is named in the external tools.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Ensure that we default to the previously selected disk
when re-entering the media selection screen.
Fixes: #515
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
The VerifyWithBundles function is used to install contents into the
target, download offline contents, and to create the initrd for the ISO.
Now, a prefix string will be added to the output of these commands to
specify which step VerifyWithBundles is running.
Signed-off-by: John Akre <john.w.akre@intel.com>
The indeterminate progress bar does not behave as expected when pulsing
twice consecutively. In this case, the progress bar moves very, very
slowly. When the progress bar pulses once, it smoothly moves back and
forth across the screen.
Signed-off-by: John Akre <john.w.akre@intel.com>
Network checks are no longer a hard requirement with offline install
support, so the precheck page should not prevent users from advancing.
This change creates a fatal pop-up window for system check failures and
removes the precheck page. Network checks will be performed as needed.
Signed-off-by: John Akre <john.w.akre@intel.com>
When a network connection is required to complete an install, but the
installer's network state is not passing, a network check will be
performed. If the network check fails, additional bundles were selected,
and offline installs are supported, the user will be prompted to remove
the additional bundles so that they can continue the install.
Signed-off-by: John Akre <john.w.akre@intel.com>
The bundle page will peform a network check when the network state is
not passing. Users will be unable to select additional bundles when the
network check fails.
Signed-off-by: John Akre <john.w.akre@intel.com>
A network check page was added to the menu. Similarly to the TUI, the
network check page will launch a pop-up window and perform a network
check.
Signed-off-by: John Akre <john.w.akre@intel.com>
The support for using encrypted file systems with advanced disk
configuration needs a lot more work.
Tracking new GitHub Issue in #512
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
The GUI need to be updated to ensure that the user defined state
was updated so that we store the user's answer in the (temp) YAML.
Make the GUI be consistent with the TUI and with the other
two selection labels for the Disk configuration.
Change advanced to warning
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
- model: Store precheck status in model
- Refactor sudo user into reusable function
- Enable the partitioning tool button
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Show the user the changes that will happen to media before
confirming the start of the installation.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Change InstallSelected to be a map with the key being
the name of the TargetMedias from the model to support
installing across multiple disks.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
The disk device name is show in the configured information, but
was missing in the chooser list. User had request this to be able
to differentiate between two drives of the same model.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
William Douglas