As of go 1.14 JSON decoder no longer accepts invalid numbers.
https://golang.org/doc/go1.14#encoding/json
Switch Version to a new type and add Unmarshaler to handle the
type which allows unsigned integer or 'latest' as valid values.
Dropped required coverage by 1% for model.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Change the AutoUpdate model type from bool to boolset to account
for default of true and state if the value was explicitly set.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
New default is the creation of a /var/swapfile if not
swap partition is explicitly defined in the YAML file
or via Advanced Configuration.
Now use and report media sizes in XiB
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Fixes: #517
Enable the possibility of no /boot partition in legacy mode.
- add warning if no /boot and legacy
Warn the user that installing in legacy mode without a /boot
partition means the install will never boot in UEFI mode.
- Force off 64bit mode
When an ext file system is used for the /boot content
(no /boot partition, and booting legacy mode) we need to
disable 64bit flag or the image file system not boot.
https://wiki.syslinux.org/wiki/index.php?title=Filesystem#ext
- Blocked use of XFS due to partition table requirement to use MBR.
- Do not allow encryption of / w/o /boot
Refactor validation code for reuse by both standard and advanced
disk partitioning. Add new standard Desktop and Server wrapper
functions.
Move validation to common function, remove from Find Targets, and
remove redundant validation function.
Enable the skip size for advanced partitions.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Add command line arguments and YAML file configurations for settings
skipping partition size checks during validation.
Skip Validation All implies Skip Size.
Never write skip validation options to YAML
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Add the publisher and the application/image type to the ISO.
- ApplicationId set to 'server' by default, 'desktop' if any
bundles are included which contain the name 'desktop.
- ApplicationId can be overridden via the YAML file
- Publisher only set if included in YAML file
Add new test coverage.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Fixes: #600
Only copy the swupd configuration files from the host to the target
by default when running the interactive installer (gui or tui).
Otherwise, observe the setting from the configuration YAML or the
command line (highest) argument.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Ensure we do not allow the user to set options, either
via command line or in the default configuration file,
which would not be valid during an interactive installation.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
When converting an ister JSON configuration file to a
clr-installer YAML configuration file, we want to ensure
a single kernel is set. Additional kernel result in a
warning as ISO mainly due to ISO generation limitation
in the code.
Add new coverage test for multiple kernels.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
No easy way to test all of the error conditions of
Marshaling and Unmarshaling, so dropping the coverage by 1%
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Fixes Issue: #242
Only show user selected bundles on the summary menu item for
bundle selection; not core, required bundles.
Make the latest user bundle changes more evident by prepending
them to the list of bundles to install.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
- The new -j flag detects ister json config format and converts it to yaml
- The existing -c flag also detects ister json config format, converts it to yaml
and continues as usual
- Handles the ister "rest" option for physical targets
- Handles multiple targets
Signed-off-by: Reagan Lopez <reagan.lopez@intel.com>
Add the user's ssh-keys configuration support as well as the required
bits to creathe the authorized_keys file.
Signed-off-by: Leandro Dorileo <leandro.maciel.dorileo@intel.com>
With the --block-device command line argument the user can remap
or add an entry to configuration file's block-devices definition.
Signed-off-by: Leandro Dorileo <leandro.maciel.dorileo@intel.com>
A alias can be used for a single partition only, this test makes
sure we test the case.
Signed-off-by: Leandro Dorileo <leandro.maciel.dorileo@intel.com>
- Hid the makefile comment
- Catch additional test case that need to clean up the
temp downloaded file
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
I started increasing the minimal test but it's minimal for a reason -
to be minimal.
This patch moves the pre and post hook tests to their own test file.
Signed-off-by: Leandro Dorileo <leandro.maciel.dorileo@intel.com>
With this the user can add alias block devices and use these alias
to expand target media's Name values, i.e:
block-devices: [
{name: "target", file: "/dev/sda"}
]
targetMedia:
- name: ${target}
type: disk
...
Signed-off-by: Leandro Dorileo <leandro.maciel.dorileo@intel.com>
The mass-installer use case for image generation requires to specify
the target system version. This patch allows the configuration of
an arbitrary version.
Signed-off-by: Leandro Dorileo <leandro.maciel.dorileo@intel.com>
Introduce a minimal valid test, it shows the use of only the required
fields - specially for storage/media configurations.
Signed-off-by: Leandro Dorileo <leandro.maciel.dorileo@intel.com>
We are relying on clr-boot-manager's cmdline-removal feature which
prevents a kernel argument to be added to the boot manager kernel
entry.
Signed-off-by: Leandro Dorileo <leandro.maciel.dorileo@intel.com>
This patch fixes the tests coverage regressions and add a small fix
to the script where it doesn't remove the temporary coverage report
file if it fails. Now it can be enabled on the CI and avoid adding
new testsuite regressions.
Signed-off-by: Leandro Dorileo <leandro.maciel.dorileo@intel.com>
This is code is still alpha. The Text-based User Interface is
undergoing a resign of the layout before beta.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Mark D Horn