David Benjamin a20bb7ff8b bn/asm/rsaz-avx2.pl: fix digit correction bug in rsaz_1024_mul_avx2. ...

Credit to OSS-Fuzz for finding this.

CVE-2017-3738

(Imported from upstream's 5630661aecbea5fe3c4740f5fea744a1f07a6253 and
77d75993651b63e872244a3256e37967bb3c3e9e.)

Confirmed with Intel SDE that the fix makes the test vector pass and
that, without the fix, the test vector does not. (Well, we knew the
latter already, since it was our test vector.)

Change-Id: I167aa3407ddab3b434bacbd18e099c55aa40ac4c
Reviewed-on: https://boringssl-review.googlesource.com/23884
Reviewed-by: Adam Langley <agl@google.com>
(cherry picked from commit 296a61d600)
Reviewed-on: https://boringssl-review.googlesource.com/23964
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>

2017-12-11 19:33:36 +00:00

..

asn1

Reimplement OBJ_txt2obj and add a lower-level function.

2017-11-27 21:29:00 +00:00

base64

Run the comment converter on libcrypto.

2017-08-18 21:49:04 +00:00

bio

Remove now unnecessary _POSIX_C_SOURCE bits to work around macOS bug.

2017-10-02 20:02:22 +00:00

bn_extra

Remove the buggy RSA parser.

2017-10-24 17:39:46 +00:00

buf

Always process handshake records in full.

2017-10-17 14:53:11 +00:00

bytestring

Revert "Support high tag numbers in CBS/CBB."

2017-12-07 17:56:58 +00:00

chacha

Run the comment converter on libcrypto.

2017-08-18 21:49:04 +00:00

cipher_extra

Explicit fallthrough on switch

2017-09-20 19:58:25 +00:00

cmac

Run the comment converter on libcrypto.

2017-08-18 21:49:04 +00:00

conf

Add more compatibility symbols for Node.

2017-11-03 01:31:50 +00:00

curve25519

Move curve25519 code to third_party/fiat.

2017-11-03 22:23:59 +00:00

dh

Fx DH_set0_pqg.

2017-10-05 18:50:48 +00:00

digest_extra

Export EVP_parse_digest_algorithm and add EVP_marshal_digest_algorithm.

2017-09-25 20:44:13 +00:00

dsa

Remove DSA_sign_setup too.

2017-11-22 21:01:11 +00:00

ec_extra

Support high tag numbers in CBS/CBB.

2017-11-22 22:34:05 +00:00

ecdh

Check EC_POINT/EC_GROUP compatibility more accurately.

2017-10-28 08:02:50 +00:00

ecdsa_extra

Remove ECDSA_sign_setup and friends.

2017-11-22 20:23:40 +00:00

engine

Run the comment converter on libcrypto.

2017-08-18 21:49:04 +00:00

err

Reimplement OBJ_txt2obj and add a lower-level function.

2017-11-27 21:29:00 +00:00

evp

Add some missing OpenSSL 1.1.0 accessors.

2017-11-22 18:43:38 +00:00

fipsmodule

bn/asm/rsaz-avx2.pl: fix digit correction bug in rsaz_1024_mul_avx2.

2017-12-11 19:33:36 +00:00

hkdf

Run the comment converter on libcrypto.

2017-08-18 21:49:04 +00:00

hmac_extra

Convert a number of tests to GTest.

2017-06-01 17:02:13 +00:00

lhash

Unexport more of lhash.

2017-10-25 04:17:18 +00:00

obj

Reimplement OBJ_txt2obj and add a lower-level function.

2017-11-27 21:29:00 +00:00

pem

Clear some _CRT_SECURE_NO_WARNINGS warnings.

2017-10-25 04:14:28 +00:00

perlasm

Revert assembly changes in "Hide CPU capability symbols in C."

2017-10-30 20:39:57 +00:00

pkcs7

Run the comment converter on libcrypto.

2017-08-18 21:49:04 +00:00

pkcs8

Export EVP_parse_digest_algorithm and add EVP_marshal_digest_algorithm.

2017-09-25 20:44:13 +00:00

poly1305

Remove custom memcpy and memset from poly1305_vec.

2017-11-10 20:53:30 +00:00

pool

Run the comment converter on libcrypto.

2017-08-18 21:49:04 +00:00

rand_extra

Remove CHROMIUM_ROLLING_MAGENTA_TO_ZIRCON scaffolding.

2017-09-18 21:34:32 +00:00

rc4

Simplify RC4 code and remove assembly.

2016-08-30 15:32:31 +00:00

rsa_extra

Make BN_generate_dsa_nonce internally constant-time.

2017-11-20 16:18:30 +00:00

stack

Run the comment converter on libcrypto.

2017-08-18 21:49:04 +00:00

test

Clarify ERR_print_errors_* clear the error queue.

2017-09-05 17:31:25 +00:00

x509

Revert "Support high tag numbers in CBS/CBB."

2017-12-07 17:56:58 +00:00

x509v3

Pretty-print large INTEGERs and ENUMERATEDs in hex.

2017-11-27 18:38:50 +00:00

CMakeLists.txt

Move curve25519 code to third_party/fiat.

2017-11-03 22:23:59 +00:00

compiler_test.cc

Test that nullptr has the obvious memory representation.

2017-07-28 17:39:28 +00:00

constant_time_test.cc

Switch constant-time functions to using |crypto_word_t|.

2017-04-21 22:06:05 +00:00

cpu-aarch64-linux.c

Run the comment converter on libcrypto.

2017-08-18 21:49:04 +00:00

cpu-arm-linux.c

Add CRYPTO_needs_hwcap2_workaround.

2017-09-18 14:05:46 +00:00

cpu-arm.c

Rewrite ARM feature detection.

2016-03-26 04:54:44 +00:00

cpu-intel.c

Use unsigned integers for masks.

2017-10-30 18:39:58 +00:00

cpu-ppc64le.c

Run the comment converter on libcrypto.

2017-08-18 21:49:04 +00:00

crypto.c

Hide CPU capability symbols in C.

2017-10-23 18:36:49 +00:00

ex_data.c

Unexport more of lhash.

2017-10-25 04:17:18 +00:00

internal.h

Tidy up alignof #defines.

2017-09-25 14:20:54 +00:00

mem.c

Remove now unnecessary _POSIX_C_SOURCE bits to work around macOS bug.

2017-10-02 20:02:22 +00:00

refcount_c11.c

Run the comment converter on libcrypto.

2017-08-18 21:49:04 +00:00

refcount_lock.c

Run the comment converter on libcrypto.

2017-08-18 21:49:04 +00:00

refcount_test.cc

Convert various tests to GTest.

2017-05-23 22:34:09 +00:00

thread_none.c

Run the comment converter on libcrypto.

2017-08-18 21:49:04 +00:00

thread_pthread.c

Run the comment converter on libcrypto.

2017-08-18 21:49:04 +00:00

thread_test.cc

Run the comment converter on libcrypto.

2017-08-18 21:49:04 +00:00

thread_win.c

Run the comment converter on libcrypto.

2017-08-18 21:49:04 +00:00

thread.c

Remove a bunch of unnecessary includes.

2016-06-28 20:31:14 +00:00