From 58745d61afe244a37941d391f5dec3ab08f5cf2c Mon Sep 17 00:00:00 2001 From: David Benjamin Date: Mon, 20 May 2024 15:48:01 -0400 Subject: [PATCH] Disable DilithiumTest.BitFlips test This test is very slow. Even BoringSSL's CI got noticeably slower after it was enabled. It should hopefully be redundant with the test vectors, supposing the test vectors were generated well. (The test is still available to be run manually.) Bug: chromium:341639202 Change-Id: Ica248c6643458988e45e50d5ec80718b5ff4bb5f Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/68627 Auto-Submit: David Benjamin Commit-Queue: David Benjamin Commit-Queue: Adam Langley Reviewed-by: Adam Langley --- crypto/dilithium/dilithium_test.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crypto/dilithium/dilithium_test.cc b/crypto/dilithium/dilithium_test.cc index 3918142ff..b0bb2edf7 100644 --- a/crypto/dilithium/dilithium_test.cc +++ b/crypto/dilithium/dilithium_test.cc @@ -28,7 +28,8 @@ #include "./internal.h" -TEST(DilithiumTest, BitFlips) { +// This test is very slow, so it is disabled by default. +TEST(DilithiumTest, DISABLED_BitFlips) { auto encoded_public_key = std::make_unique(DILITHIUM_PUBLIC_KEY_BYTES); auto priv = std::make_unique();