From f913458a1666fc8d5465ab3af8a086f19e67b7d1 Mon Sep 17 00:00:00 2001 From: Eric Biggers Date: Tue, 10 Dec 2024 22:02:40 +0000 Subject: [PATCH] Add missing $ to immediate in aes-gcm-avx10-x86_64.pl Found by code review. It worked anyway because the line is only included in the Windows NASM file. But omitting the $ is inconsistent. No change to the generated asm files. Change-Id: I12aa43fd9d71d7a71bbfdf2a47de7f23dd493cfa Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/74107 Commit-Queue: David Benjamin Reviewed-by: David Benjamin --- crypto/fipsmodule/modes/asm/aes-gcm-avx10-x86_64.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/fipsmodule/modes/asm/aes-gcm-avx10-x86_64.pl b/crypto/fipsmodule/modes/asm/aes-gcm-avx10-x86_64.pl index b65dee980..9ff7367ff 100644 --- a/crypto/fipsmodule/modes/asm/aes-gcm-avx10-x86_64.pl +++ b/crypto/fipsmodule/modes/asm/aes-gcm-avx10-x86_64.pl @@ -169,7 +169,7 @@ sub _end_func { my $pos = 16 * $i; $code .= "movdqa $pos(%rsp), %xmm$reg_num\n"; } - $code .= "add $alloc_size, %rsp\n"; + $code .= "add \$$alloc_size, %rsp\n"; } # Restore any general purpose registers that were saved earlier.