From d53bbba11f164a275659d48356e992537e07774e Mon Sep 17 00:00:00 2001 From: David Benjamin Date: Sun, 12 Nov 2023 15:14:16 -0500 Subject: [PATCH] Unexport the idp_flags constants Avoid polluting the global namespace a bit. The idp_flags field itself is private, so it is impossible for a caller to do anything useful with it. Change-Id: I5853e72a3f37a93c75fb73ed5d7ca467b9ba01a3 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/63939 Reviewed-by: Bob Beck Commit-Queue: David Benjamin --- crypto/x509/internal.h | 16 ++++++++++++++++ include/openssl/x509v3.h | 18 ------------------ 2 files changed, 16 insertions(+), 18 deletions(-) diff --git a/crypto/x509/internal.h b/crypto/x509/internal.h index 47701a8de..7de539f94 100644 --- a/crypto/x509/internal.h +++ b/crypto/x509/internal.h @@ -206,6 +206,22 @@ typedef struct { // an |X509_NAME|. DECLARE_ASN1_FUNCTIONS(X509_CRL_INFO) +// Values in idp_flags field +// IDP present +#define IDP_PRESENT 0x1 +// IDP values inconsistent +#define IDP_INVALID 0x2 +// onlyuser true +#define IDP_ONLYUSER 0x4 +// onlyCA true +#define IDP_ONLYCA 0x8 +// onlyattr true +#define IDP_ONLYATTR 0x10 +// indirectCRL true +#define IDP_INDIRECT 0x20 +// onlysomereasons present +#define IDP_REASONS 0x40 + struct X509_crl_st { // actual signature X509_CRL_INFO *crl; diff --git a/include/openssl/x509v3.h b/include/openssl/x509v3.h index d7b9e8bb0..2be0e54d1 100644 --- a/include/openssl/x509v3.h +++ b/include/openssl/x509v3.h @@ -308,24 +308,6 @@ struct ISSUING_DIST_POINT_st { int onlyattr; }; -// Values in idp_flags field -// IDP present -#define IDP_PRESENT 0x1 -// IDP values inconsistent -#define IDP_INVALID 0x2 -// onlyuser true -#define IDP_ONLYUSER 0x4 -// onlyCA true -#define IDP_ONLYCA 0x8 -// onlyattr true -#define IDP_ONLYATTR 0x10 -// indirectCRL true -#define IDP_INDIRECT 0x20 -// onlysomereasons present -#define IDP_REASONS 0x40 - - - // X509_PURPOSE stuff #define EXFLAG_BCONS 0x1