From c5cc88d800605228dbbaecdff58147c073fbb2c1 Mon Sep 17 00:00:00 2001 From: David Benjamin Date: Mon, 18 Sep 2017 14:51:27 -0400 Subject: [PATCH] Test that movsd without arguments is left as-is. This works fine, but probably worth a test. Change-Id: If060b473958c1664e450102cafe0ca28951bff49 Reviewed-on: https://boringssl-review.googlesource.com/20444 Reviewed-by: Adam Langley Commit-Queue: Adam Langley CQ-Verified: CQ bot account: commit-bot@chromium.org --- util/fipstools/testdata/x86_64-GOTRewrite/in.s | 3 +++ util/fipstools/testdata/x86_64-GOTRewrite/out.s | 3 +++ 2 files changed, 6 insertions(+) diff --git a/util/fipstools/testdata/x86_64-GOTRewrite/in.s b/util/fipstools/testdata/x86_64-GOTRewrite/in.s index 3b7bbfbf4..9b4b201d1 100644 --- a/util/fipstools/testdata/x86_64-GOTRewrite/in.s +++ b/util/fipstools/testdata/x86_64-GOTRewrite/in.s @@ -26,6 +26,9 @@ foo: movsd foo@GOTPCREL(%rip), %xmm0 vmovsd foo@GOTPCREL(%rip), %xmm0 + # movsd without arguments should be left as-is. + movsd + # Synthesized symbols do not use the GOT. movq BORINGSSL_bcm_text_start@GOTPCREL(%rip), %r11 movq foobar_bss_get@GOTPCREL(%rip), %r11 diff --git a/util/fipstools/testdata/x86_64-GOTRewrite/out.s b/util/fipstools/testdata/x86_64-GOTRewrite/out.s index 68666237e..0e07721ed 100644 --- a/util/fipstools/testdata/x86_64-GOTRewrite/out.s +++ b/util/fipstools/testdata/x86_64-GOTRewrite/out.s @@ -113,6 +113,9 @@ foo: popq %rax leaq 128(%rsp), %rsp + # movsd without arguments should be left as-is. + movsd + # Synthesized symbols do not use the GOT. # WAS movq BORINGSSL_bcm_text_start@GOTPCREL(%rip), %r11 leaq BORINGSSL_bcm_text_start(%rip), %r11