From be21ef7012f0812bb1c0c8fc226979fa6c301e8d Mon Sep 17 00:00:00 2001 From: Mikael Persson Date: Mon, 9 Dec 2024 13:53:34 -0500 Subject: [PATCH] Don't impose Werror on users of BoringSSL Change-Id: Ibc52fbe362728134fce3c90ee47a23065a2e31b2 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/74087 Reviewed-by: Adam Langley Reviewed-by: David Benjamin Commit-Queue: Adam Langley --- .bazelrc | 6 ++++++ util/util.bzl | 1 - 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.bazelrc b/.bazelrc index 62c7d204b..24eb0ddf9 100644 --- a/.bazelrc +++ b/.bazelrc @@ -33,6 +33,12 @@ build:linux --cxxopt=-std=c++17 build:macos --cxxopt=-std=c++17 build:windows --cxxopt=/std:c++17 +# Our own builds should strictly build without warnings, but we don't add those +# in targets like other flags because we can't assume all users will have clean +# builds too. +build:linux --cxxopt=-Werror +build:macos --cxxopt=-Werror + # Without setting a minimum macOS version, std::optional does not work. build:macos --cxxopt=-mmacosx-version-min=10.15 diff --git a/util/util.bzl b/util/util.bzl index 3d747dbd0..a94caeb60 100644 --- a/util/util.bzl +++ b/util/util.bzl @@ -22,7 +22,6 @@ load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library", "cc_test") gcc_copts = [ # This list of warnings should match those in the top-level CMakeLists.txt. "-Wall", - "-Werror", "-Wformat=2", "-Wsign-compare", "-Wmissing-field-initializers",