From 9224e6d138f789b2db9f23b40dd016fffcdfd59e Mon Sep 17 00:00:00 2001 From: David Benjamin Date: Tue, 3 Sep 2024 19:18:50 -0400 Subject: [PATCH] Fix all_tests.go test counts The numerator is per shard, but the denominator wasn't. Change-Id: I1afd784038c51b8db51192b9a2b391073675e390 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/70867 Reviewed-by: Bob Beck Commit-Queue: Bob Beck Auto-Submit: David Benjamin --- util/all_tests.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/util/all_tests.go b/util/all_tests.go index 3b31ded40..6587b54f9 100644 --- a/util/all_tests.go +++ b/util/all_tests.go @@ -395,10 +395,12 @@ func main() { testOutput := testresult.NewResults() var failed, skipped []test + var total int for testResult := range results { test := testResult.Test args := test.Cmd + total++ if testResult.Error == errTestSkipped { fmt.Printf("%s\n", test.longName()) fmt.Printf("%s was skipped\n", args[0]) @@ -427,14 +429,14 @@ func main() { } if len(skipped) > 0 { - fmt.Printf("\n%d of %d tests were skipped:\n", len(skipped), len(testCases)) + fmt.Printf("\n%d of %d tests were skipped:\n", len(skipped), total) for _, test := range skipped { fmt.Printf("\t%s\n", test.shortName()) } } if len(failed) > 0 { - fmt.Printf("\n%d of %d tests failed:\n", len(failed), len(testCases)) + fmt.Printf("\n%d of %d tests failed:\n", len(failed), total) for _, test := range failed { fmt.Printf("\t%s\n", test.shortName()) }