From 14a2f35b6e06756902eaa7e188a25895721055fc Mon Sep 17 00:00:00 2001 From: Roland Shoemaker Date: Wed, 24 Jul 2024 11:08:44 -0700 Subject: [PATCH] Clarify SCT resumption comment Change-Id: I35de23635dbc56fb355492fefa1c052a1fdb4fb8 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/69827 Reviewed-by: David Benjamin Commit-Queue: David Benjamin --- ssl/test/runner/runner.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ssl/test/runner/runner.go b/ssl/test/runner/runner.go index 18ed78ba5..97eac0277 100644 --- a/ssl/test/runner/runner.go +++ b/ssl/test/runner/runner.go @@ -8516,8 +8516,10 @@ func addExtensionTests() { differentSCTList = append(differentSCTList, testSCTList...) differentSCTList[len(differentSCTList)-1] ^= 1 - // The SCT extension did not specify that it must only be sent on resumption as it - // should have, so test that we tolerate but ignore it. + // The SCT extension did not specify that it must only be sent on the inital handshake as it + // should have, so test that we tolerate but ignore it. This is only an issue pre-1.3, since + // SCTs are sent in the CertificateEntry message in 1.3, whereas they were previously sent + // in an extension in the ServerHello pre-1.3. testCases = append(testCases, testCase{ protocol: protocol, name: "SendSCTListOnResume-" + suffix,