From 3599db2e40df28f0f1335f5f00dd2bf0e5d2684a Mon Sep 17 00:00:00 2001 From: Brian Smith Date: Tue, 5 Dec 2023 19:15:30 -0800 Subject: [PATCH] sha: Add SSSE3 check to SHAEXT SHA-256 implementation. The implementation does use SSSE3 (palignr, pshufb). Change-Id: I86a44c1dc505b27b87fdc3cc7f6e8115abb3dcc9 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/64567 Reviewed-by: David Benjamin Reviewed-by: Bob Beck Commit-Queue: Bob Beck --- crypto/fipsmodule/sha/internal.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crypto/fipsmodule/sha/internal.h b/crypto/fipsmodule/sha/internal.h index b55ea8e5e..0c05d73a1 100644 --- a/crypto/fipsmodule/sha/internal.h +++ b/crypto/fipsmodule/sha/internal.h @@ -126,7 +126,8 @@ void sha1_block_data_order_ssse3(uint32_t *state, const uint8_t *data, #define SHA256_ASM_HW OPENSSL_INLINE int sha256_hw_capable(void) { - return CRYPTO_is_x86_SHA_capable(); + // Note that the original assembly did not check SSSE3. + return CRYPTO_is_x86_SHA_capable() && CRYPTO_is_SSSE3_capable(); } #define SHA256_ASM_AVX