From 625f68bf35248c9f47c964ce782567aafa4e2f55 Mon Sep 17 00:00:00 2001 From: David Benjamin Date: Fri, 26 Jan 2024 13:37:48 -0500 Subject: [PATCH] Tweak generate_build_files.py output to pass gn's formatter Chromium's presubmits check for files to be correctly formatted. While this is automatically generated, the tooling doesn't know this. Just output in the format it expects, which is that length 0 and length one lists are formatted differently. Change-Id: I3c5bec884db302f780c5c53429dfe26cb4731d58 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/65828 Reviewed-by: Bob Beck Auto-Submit: David Benjamin Reviewed-by: Adam Langley Commit-Queue: David Benjamin --- util/generate_build_files.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/util/generate_build_files.py b/util/generate_build_files.py index 41d5a50cb..e25a757be 100644 --- a/util/generate_build_files.py +++ b/util/generate_build_files.py @@ -339,10 +339,15 @@ class GN(object): out.write('\n') self.firstSection = False - out.write('%s = [\n' % name) - for f in sorted(files): - out.write(' "%s",\n' % f) - out.write(']\n') + if len(files) == 0: + out.write('%s = []\n' % name) + elif len(files) == 1: + out.write('%s = [ "%s" ]\n' % (name, files[0])) + else: + out.write('%s = [\n' % name) + for f in sorted(files): + out.write(' "%s",\n' % f) + out.write(']\n') def WriteFiles(self, files): with open('BUILD.generated.gni', 'w+') as out: