From 3873f6f33d3faa5ff5cd34d4b094978862da2f6d Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Thu, 24 Jul 2014 23:33:34 +0100 Subject: [PATCH] Added comment for the frag->reassembly == NULL case as per feedback from Emilia MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reviewed-by: Emilia Käsper (Imported from upstream's ea7cb5397457c59554155935b677a1dab23bd864) Change-Id: Idd5ed233028c42d2b921deb424381aad88a0aa84 Reviewed-on: https://boringssl-review.googlesource.com/1433 Reviewed-by: Adam Langley --- ssl/d1_both.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ssl/d1_both.c b/ssl/d1_both.c index fef8b45ae..b0e749c3d 100644 --- a/ssl/d1_both.c +++ b/ssl/d1_both.c @@ -645,14 +645,14 @@ dtls1_reassemble_fragment(SSL *s, struct hm_header_st* msg_hdr, int *ok) } } - /* If message is already reassembled, this must be a - * retransmit and can be dropped. - */ + * retransmit and can be dropped. In this case item != NULL and so frag + * does not need to be freed. */ if (frag->reassembly == NULL) { unsigned char devnull [256]; + assert(item != NULL); while (frag_len) { i = s->method->ssl_read_bytes(s,SSL3_RT_HANDSHAKE,