From 2958490127dbe0df3adb72bc8ffb04ebca1f4bbf Mon Sep 17 00:00:00 2001
From: Adam Langley <agl@chromium.org>
Date: Mon, 16 Sep 2024 13:43:03 -0700
Subject: [PATCH] slhdsa: fix some ClangTidy warnings.

Change-Id: I9dca8533a59e214707862d6ece233a4332ced4d3
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/71328
Commit-Queue: Adam Langley <agl@google.com>
Auto-Submit: Adam Langley <agl@google.com>
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
---
 crypto/slhdsa/slhdsa.c       | 5 +++--
 crypto/slhdsa/slhdsa_test.cc | 1 -
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/crypto/slhdsa/slhdsa.c b/crypto/slhdsa/slhdsa.c
index ca04c3daf..d8f0797e1 100644
--- a/crypto/slhdsa/slhdsa.c
+++ b/crypto/slhdsa/slhdsa.c
@@ -50,10 +50,11 @@ void SLHDSA_SHA2_128S_generate_key_from_seed(
 
 void SLHDSA_SHA2_128S_generate_key(
     uint8_t out_public_key[SLHDSA_SHA2_128S_PUBLIC_KEY_BYTES],
-    uint8_t out_secret_key[SLHDSA_SHA2_128S_PRIVATE_KEY_BYTES]) {
+    uint8_t out_private_key[SLHDSA_SHA2_128S_PRIVATE_KEY_BYTES]) {
   uint8_t seed[3 * SLHDSA_SHA2_128S_N];
   RAND_bytes(seed, 3 * SLHDSA_SHA2_128S_N);
-  SLHDSA_SHA2_128S_generate_key_from_seed(out_public_key, out_secret_key, seed);
+  SLHDSA_SHA2_128S_generate_key_from_seed(out_public_key, out_private_key,
+                                          seed);
 }
 
 OPENSSL_EXPORT void SLHDSA_SHA2_128S_public_from_private(
diff --git a/crypto/slhdsa/slhdsa_test.cc b/crypto/slhdsa/slhdsa_test.cc
index fe70fbdc9..56fe3b1ca 100644
--- a/crypto/slhdsa/slhdsa_test.cc
+++ b/crypto/slhdsa/slhdsa_test.cc
@@ -19,7 +19,6 @@
 #include <vector>
 
 #include <gtest/gtest.h>
-#include <openssl/bytestring.h>
 #include <openssl/slhdsa.h>
 
 #include "../test/file_test.h"