diff --git a/BUILD.generated.bzl b/BUILD.generated.bzl index f474a1732..8aa39df80 100644 --- a/BUILD.generated.bzl +++ b/BUILD.generated.bzl @@ -171,13 +171,13 @@ crypto_headers = [ "src/include/openssl/evp.h", "src/include/openssl/evp_errors.h", "src/include/openssl/ex_data.h", + "src/include/openssl/experimental/kyber.h", "src/include/openssl/hkdf.h", "src/include/openssl/hmac.h", "src/include/openssl/hpke.h", "src/include/openssl/hrss.h", "src/include/openssl/is_boringssl.h", "src/include/openssl/kdf.h", - "src/include/openssl/kyber.h", "src/include/openssl/lhash.h", "src/include/openssl/md4.h", "src/include/openssl/md5.h", diff --git a/sources.json b/sources.json index 6f42050a5..12ecf1165 100644 --- a/sources.json +++ b/sources.json @@ -405,13 +405,13 @@ "src/include/openssl/evp.h", "src/include/openssl/evp_errors.h", "src/include/openssl/ex_data.h", + "src/include/openssl/experimental/kyber.h", "src/include/openssl/hkdf.h", "src/include/openssl/hmac.h", "src/include/openssl/hpke.h", "src/include/openssl/hrss.h", "src/include/openssl/is_boringssl.h", "src/include/openssl/kdf.h", - "src/include/openssl/kyber.h", "src/include/openssl/lhash.h", "src/include/openssl/md4.h", "src/include/openssl/md5.h", diff --git a/src/API-CONVENTIONS.md b/src/API-CONVENTIONS.md index ec08e57a2..e36037bb2 100644 --- a/src/API-CONVENTIONS.md +++ b/src/API-CONVENTIONS.md @@ -16,6 +16,9 @@ OpenSSL's legacy ASN.1, X.509, and PEM implementation. If possible, avoid using them. These are left largely unmodified from upstream and are retained only for compatibility with existing OpenSSL consumers. +Experimental public APIs are found in `include/openssl/experimental`. Use of +these will likely be incompatible with changes in the near future as they are +finalized. ## Forward declarations diff --git a/src/crypto/kyber/internal.h b/src/crypto/kyber/internal.h index 7f4a08c2e..007226904 100644 --- a/src/crypto/kyber/internal.h +++ b/src/crypto/kyber/internal.h @@ -16,7 +16,7 @@ #define OPENSSL_HEADER_CRYPTO_KYBER_INTERNAL_H #include -#include +#include #if defined(__cplusplus) extern "C" { diff --git a/src/crypto/kyber/kyber.c b/src/crypto/kyber/kyber.c index e9e3a9198..0e973590e 100644 --- a/src/crypto/kyber/kyber.c +++ b/src/crypto/kyber/kyber.c @@ -12,7 +12,7 @@ * OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ -#include +#include #include #include diff --git a/src/crypto/kyber/kyber_test.cc b/src/crypto/kyber/kyber_test.cc index c42db787c..99564788b 100644 --- a/src/crypto/kyber/kyber_test.cc +++ b/src/crypto/kyber/kyber_test.cc @@ -20,7 +20,7 @@ #include #include -#include +#include #include "../test/file_test.h" #include "../test/test_util.h" diff --git a/src/include/openssl/kyber.h b/src/include/openssl/experimental/kyber.h similarity index 100% rename from src/include/openssl/kyber.h rename to src/include/openssl/experimental/kyber.h diff --git a/src/ssl/ssl_key_share.cc b/src/ssl/ssl_key_share.cc index 80317d898..f4fda3fda 100644 --- a/src/ssl/ssl_key_share.cc +++ b/src/ssl/ssl_key_share.cc @@ -24,7 +24,7 @@ #include #include #include -#include +#include #include #include #include diff --git a/src/tool/speed.cc b/src/tool/speed.cc index 547390946..a8c058731 100644 --- a/src/tool/speed.cc +++ b/src/tool/speed.cc @@ -38,8 +38,8 @@ #include #include #include +#include #include -#include #include #include #include diff --git a/src/util/doc.config b/src/util/doc.config index e36a9601d..2e71c3c65 100644 --- a/src/util/doc.config +++ b/src/util/doc.config @@ -36,7 +36,6 @@ "include/openssl/engine.h", "include/openssl/hkdf.h", "include/openssl/hmac.h", - "include/openssl/kyber.h", "include/openssl/md5.h", "include/openssl/rc4.h", "include/openssl/rsa.h", @@ -60,6 +59,11 @@ "include/openssl/conf.h", "include/openssl/x509.h" ] + },{ + "Name": "Experimental primitives. Will be removed and replaced when standardized!", + "Headers": [ + "include/openssl/experimental/kyber.h" + ] },{ "Name": "SSL implementation", "Headers": [